extant2000/flamenet-relay
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

The footer link to /releases turned main red #131

Merged
paulhitt merged 1 commits from fix/the-layout-may-link-to-releases into main 2026-09-05 22:25:07 +00:00
Conversation 2 Commits 1 Files Changed 1
+10 -1
paulhitt commented 2026-09-05 20:17:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

testTheLayoutLinksOnlyToPagesThatExist derives what exists from the pages table, and /releases is deliberately outside it — its content is data read per request so a release appears without a restart.

Third place that needed the same exception: the deploy gate, the gate's page count, and now this test. Worth revisiting the pattern rather than extending it a fourth time.

It shipped because I merged the footer MR past a starved runner on the reasoning that the deploy gate covers every page. The gate did pass — because it had been taught about /releases an hour earlier. The check that hadn't been taught was the one I skipped.

Unblocks !58, !53 and !10, which have been sitting behind a red main.

`testTheLayoutLinksOnlyToPagesThatExist` derives what exists from the `pages` table, and `/releases` is deliberately outside it — its content is data read per request so a release appears without a restart. Third place that needed the same exception: the deploy gate, the gate's page count, and now this test. Worth revisiting the pattern rather than extending it a fourth time. It shipped because I merged the footer MR past a starved runner on the reasoning that the deploy gate covers every page. The gate did pass — because it had been taught about /releases an hour earlier. The check that hadn't been taught was the one I skipped. Unblocks !58, !53 and !10, which have been sitting behind a red main.
paulhitt commented 2026-09-05 22:25:08 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 7adbf02ddb

mentioned in commit 7adbf02ddb0fad329034d7cef18df25b130368c5
paulhitt (Migrated from gitlab.com) merged commit 7adbf02ddb into main 2026-09-05 22:25:08 +00:00
paulhitt commented 2026-09-09 18:58:52 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed the description

changed the description
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accuracy
A public page claims something the code does not do
 architecture
blocked:apple
Waiting on App Store review
 bug
ci
deploy
docs
federation
hardening
idea
investigation
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 planning
privacy
Changes what is stored, or what we say is stored
 reliability
scalability
security
self-hosting
signup
stability
tech-debt
tooling
unwired
Built in the engine, not reachable from the UI
 verification
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-relay#131