extant2000/flamenet-messenger-android
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Prove a group pin resolves (relay#46) #91

Merged
paulhitt merged 1 commits from test/group-pin-resolves into main 2026-09-05 00:42:43 +00:00
Conversation 3 Commits 1 Files Changed 1
+128
paulhitt commented 2026-09-05 00:41:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

The published spec says a group pin "is carried correctly on the wire but
cannot resolve yet, because a group transcript does not record" a message
id. Session.sendGroup mints a mid and passes it to record(...), so the
stated reason is already false — but relay#46's rule is that a claim is
flipped by a run, not by reading the code, and nothing exercised the group
case specifically.

Five tests, on a group thread rather than a 1:1 one, because that is what
the spec singles out: the transcript carries an id, the pin resolves to the
message it names, and a group pin does not leak into a DM.

One of them is about the design rather than the plumbing. The pin stores
an ID and never a copy, so the banner follows an edit instead of quoting
words that are no longer in the conversation — a stored copy would go stale
the moment the message changed and would outlive it being deleted.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

The published spec says a group pin "is carried correctly on the wire but cannot resolve yet, because a group transcript does not record" a message id. `Session.sendGroup` mints a mid and passes it to `record(...)`, so the stated reason is already false — but relay#46's rule is that a claim is flipped by a run, not by reading the code, and nothing exercised the group case specifically. Five tests, on a group thread rather than a 1:1 one, because that is what the spec singles out: the transcript carries an id, the pin resolves to the message it names, and a group pin does not leak into a DM. One of them is about the design rather than the plumbing. The pin stores an ID and never a copy, so the banner follows an edit instead of quoting words that are no longer in the conversation — a stored copy would go stale the moment the message changed and would outlive it being deleted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
paulhitt commented 2026-09-05 00:41:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @paulhitt

assigned to @paulhitt
paulhitt (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2026-09-05 00:41:51 +00:00
paulhitt (Migrated from gitlab.com) merged commit 99a33627a4 into main 2026-09-05 00:42:43 +00:00
paulhitt commented 2026-09-05 00:42:44 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 99a33627a4

mentioned in commit 99a33627a43a5975078dbef727f73eed6fc7a083
paulhitt commented 2026-09-09 19:01:19 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed the description

changed the description
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accounts
accuracy
A public page or doc claims something the code does not do
 android
blocked:apple
Waiting on App Store review
 blocker
bug
enhancement
hardening
idea
messages
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 privacy
Changes what is stored, or what we say is stored
 reliability
safety
security
tablet
tech-debt
testing
unwired
Built in the engine, not reachable from the UI
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#91