extant2000/flamenet-messenger-android
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

A skipped live sign-up must report skipped, not passed #58

Merged
paulhitt merged 1 commits from fix/live-signup-guard-must-skip-not-pass into main 2026-09-02 19:48:26 +00:00
Conversation 3 Commits 1 Files Changed 1
+16 -2
paulhitt commented 2026-09-02 19:30:22 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

The two live sign-up tests guarded themselves with a bare return, so
without -e live true they finished immediately and reported PASSED. A
test that did nothing and says it passed is worse than one that did not run:
a suite of those is indistinguishable from a suite that works, which is the
only reason to run it.

assumeTrue instead, with the message saying how to opt in. Assumed-out
shows as skipped, so the count reflects what was actually exercised.

The iOS side already had this reasoning written down; Android had the
comment's opposite.

Compiles: :app:compileDebugAndroidTestKotlin.

The two live sign-up tests guarded themselves with a bare `return`, so without `-e live true` they finished immediately and reported PASSED. A test that did nothing and says it passed is worse than one that did not run: a suite of those is indistinguishable from a suite that works, which is the only reason to run it. `assumeTrue` instead, with the message saying how to opt in. Assumed-out shows as skipped, so the count reflects what was actually exercised. The iOS side already had this reasoning written down; Android had the comment's opposite. Compiles: :app:compileDebugAndroidTestKotlin.
paulhitt commented 2026-09-02 19:30:22 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @paulhitt

assigned to @paulhitt
paulhitt commented 2026-09-02 19:48:14 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 11 commits

  • b3e0b81d...602ee82a - 10 commits from branch main
  • 8c8f2c1b - A skipped live sign-up must report skipped, not passed

Compare with previous version

added 11 commits <ul><li>b3e0b81d...602ee82a - 10 commits from branch <code>main</code></li><li>8c8f2c1b - A skipped live sign-up must report skipped, not passed</li></ul> [Compare with previous version](/paulhitt/flamenet-messenger-android/-/merge_requests/31/diffs?diff_id=2000734756&start_sha=b3e0b81d882b88a481c474b30f23ec143d56b279)
paulhitt commented 2026-09-02 19:48:26 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 1fc1a561b3

mentioned in commit 1fc1a561b3c57bd2862921bc431a611fc8c14aae
paulhitt (Migrated from gitlab.com) merged commit 1fc1a561b3 into main 2026-09-02 19:48:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accounts
accuracy
A public page or doc claims something the code does not do
 android
blocked:apple
Waiting on App Store review
 blocker
bug
enhancement
hardening
idea
messages
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 privacy
Changes what is stored, or what we say is stored
 reliability
safety
security
tablet
tech-debt
testing
unwired
Built in the engine, not reachable from the UI
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#58