extant2000/flamenet-messenger-android
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Recognise a pinned message (§6.19) #46

Merged
paulhitt merged 1 commits from feat/pin-a-message into main 2026-09-02 20:07:00 +00:00
Conversation 4 Commits 1 Files Changed 3
+130 -2
paulhitt commented 2026-09-02 12:50:06 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Codec only — the app does not pin yet — but without this branch an
inbound pin falls through parse to the attachment path and comes back
renderable, so every pin the iPhone app sets would draw an empty bubble
in the conversation.

isRenderable excludes it for the same reason it excludes a reaction, and
it is NOT in Kind.CONTROL: a build that swallowed it as generic control
would drop every pin while looking like it worked.

The envelope carries an id and never a copy of the message. A pin
carrying the text would keep a message readable after its own timer had
removed it, so pinning would quietly defeat disappearing messages.

Refs paulhitt/flamenet-messenger-ios#50

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

Codec only — the app does not pin yet — but without this branch an inbound pin falls through parse to the attachment path and comes back renderable, so every pin the iPhone app sets would draw an empty bubble in the conversation. isRenderable excludes it for the same reason it excludes a reaction, and it is NOT in Kind.CONTROL: a build that swallowed it as generic control would drop every pin while looking like it worked. The envelope carries an id and never a copy of the message. A pin carrying the text would keep a message readable after its own timer had removed it, so pinning would quietly defeat disappearing messages. Refs paulhitt/flamenet-messenger-ios#50 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
paulhitt commented 2026-09-02 12:50:06 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @paulhitt

assigned to @paulhitt
paulhitt commented 2026-09-02 20:06:48 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 27 commits

  • 9d33e602...400c9106 - 26 commits from branch main
  • 36146657 - Recognise a pinned message (§6.19)

Compare with previous version

added 27 commits <ul><li>9d33e602...400c9106 - 26 commits from branch <code>main</code></li><li>36146657 - Recognise a pinned message (§6.19)</li></ul> [Compare with previous version](/paulhitt/flamenet-messenger-android/-/merge_requests/19/diffs?diff_id=2000769767&start_sha=9d33e602865acc2ddbe062a34b380558d363bbb1)
paulhitt commented 2026-09-02 20:07:00 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 021dc2c24d

mentioned in commit 021dc2c24d422b1a44a01b4a541d35c16b29af48
paulhitt (Migrated from gitlab.com) merged commit 021dc2c24d into main 2026-09-02 20:07:00 +00:00
paulhitt commented 2026-09-09 19:01:50 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed the description

changed the description
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accounts
accuracy
A public page or doc claims something the code does not do
 android
blocked:apple
Waiting on App Store review
 blocker
bug
enhancement
hardening
idea
messages
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 privacy
Changes what is stored, or what we say is stored
 reliability
safety
security
tablet
tech-debt
testing
unwired
Built in the engine, not reachable from the UI
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#46