extant2000/flamenet-messenger-android
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

The echo peer outlives a failed call instead of exiting #184

Merged
paulhitt merged 1 commits from fix/echo-peer-survives-errors into main 2026-09-28 14:16:31 +00:00
Conversation 2 Commits 1 Files Changed 1
+30 -5
paulhitt commented 2026-09-28 14:12:20 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Harness only (interop/, not shipped), one file. The interop Peer autoreply loop had no catch, so one failed poll or send to the relay ended the process, and the on-device reply case waited out its 90 seconds for an echo from a peer that was gone. That fits the one missed echo seen in five full runs on 2026-09-28; its log was lost, so it is not proven. Each poll and echo is now caught, logged to stderr with a timestamp, and the loop carries on; the closing JSON adds an errors count. scripts/instrumented.sh already prints the echo log when a run fails. Checked against a relay address that refuses connections: the old peer exits 1 on the first poll; the new one runs its full 8 s, logs 4 failed polls, prints {"echoed":0,"errors":4}. Against relay1: 0 errors. Full on-device suite with the new peer: 10 of 10. 🤖 Generated with Claude Code

Harness only (interop/, not shipped), one file. The interop Peer autoreply loop had no catch, so one failed poll or send to the relay ended the process, and the on-device reply case waited out its 90 seconds for an echo from a peer that was gone. That fits the one missed echo seen in five full runs on 2026-09-28; its log was lost, so it is not proven. Each poll and echo is now caught, logged to stderr with a timestamp, and the loop carries on; the closing JSON adds an errors count. scripts/instrumented.sh already prints the echo log when a run fails. Checked against a relay address that refuses connections: the old peer exits 1 on the first poll; the new one runs its full 8 s, logs 4 failed polls, prints {"echoed":0,"errors":4}. Against relay1: 0 errors. Full on-device suite with the new peer: 10 of 10. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
paulhitt commented 2026-09-28 14:12:20 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @paulhitt

assigned to @paulhitt
paulhitt commented 2026-09-28 14:16:31 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit d53f6a81bb

mentioned in commit d53f6a81bb83ba8ff578012f217cb98ae101ee57
paulhitt (Migrated from gitlab.com) merged commit d53f6a81bb into main 2026-09-28 14:16:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accounts
accuracy
A public page or doc claims something the code does not do
 android
blocked:apple
Waiting on App Store review
 blocker
bug
enhancement
hardening
idea
messages
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 privacy
Changes what is stored, or what we say is stored
 reliability
safety
security
tablet
tech-debt
testing
unwired
Built in the engine, not reachable from the UI
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#184