Remove the dead composables and the unread stat #173

2026-09-22T14:36:13Z

paulhitt commented

2026-09-22 14:36:13 +00:00

(Migrated from gitlab.com)

A dead-code pass across all four repositories, correctly scoped this
time: overrides and protocol conformances filtered, every */src/main
covered rather than a hand-picked pair.

Relay 0 of 296 functions. Engine 0 of 93. iOS 0 of 957: the three
candidates are forgetProtoPin, which carries a comment saying not to
delete it for being unreferenced, and two
QLPreviewControllerDataSource methods the framework calls.

Android had four. Two go here: PresenceDot, whose own comment says its
colours are the previous brand's palette left behind when the accent
changed, and BarAction. Both are private composables nothing calls.
Obfs4Stats.lastHandshakeAt goes with the field written only for it;
its sibling completedHandshakes is read by NetworkSection and stays.

The fourth is announceScreenshot, which is the §6.27 gap the spec now
records. It stays until the receive path exists to pair with it.

The three stale inventories in the session scratchpad are marked as not
to be acted on. Their line numbers no longer matched the files and most
of their entries were framework callbacks.

Engine 719 and client 473 green, app and obfs4 compile.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

A dead-code pass across all four repositories, correctly scoped this time: overrides and protocol conformances filtered, every `*/src/main` covered rather than a hand-picked pair. Relay 0 of 296 functions. Engine 0 of 93. iOS 0 of 957: the three candidates are `forgetProtoPin`, which carries a comment saying not to delete it for being unreferenced, and two `QLPreviewControllerDataSource` methods the framework calls. Android had four. Two go here: `PresenceDot`, whose own comment says its colours are the previous brand's palette left behind when the accent changed, and `BarAction`. Both are private composables nothing calls. `Obfs4Stats.lastHandshakeAt` goes with the field written only for it; its sibling `completedHandshakes` is read by NetworkSection and stays. The fourth is `announceScreenshot`, which is the §6.27 gap the spec now records. It stays until the receive path exists to pair with it. The three stale inventories in the session scratchpad are marked as not to be acted on. Their line numbers no longer matched the files and most of their entries were framework callbacks. Engine 719 and client 473 green, app and obfs4 compile. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

paulhitt commented

2026-09-22 14:36:14 +00:00

(Migrated from gitlab.com)

assigned to @paulhitt

paulhitt (Migrated from gitlab.com) merged commit 183b6f528b into main

2026-09-22 14:49:44 +00:00

paulhitt commented

2026-09-22 14:49:46 +00:00

(Migrated from gitlab.com)

mentioned in commit 183b6f528b

mentioned in commit 183b6f528bccea5565511d4f0f4f3e485d6b473f

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#173