Accept answers the call, and a call that ended goes away #141

Merged
paulhitt merged 2 commits from fix/accept-actually-answers into main 2026-09-10 19:08:01 +00:00
paulhitt commented 2026-09-10 18:47:23 +00:00 (Migrated from gitlab.com)

The notification's Accept button has carried EXTRA_ANSWER_CALL since it
was written, and nothing ever read it. Pressing Accept did what any
other tap did: it opened the app. Answering was left to the next turn of
the polling loop, which refuses a parked offer older than the caller's
patience, so a call taken a little late opened the app onto nothing and
looked like it had dropped the moment you answered it.

MainActivity reads the extra now, on a cold start and on a warm one,
and answers at once rather than waiting for a tick.

The notification also goes away on its own when the offer it shows has
expired. Before, it could outlive the offer by the gap between service
sweeps, which is longer since the loop started holding its poll open,
and during that gap it was a button that could only disappoint.

Seen on the emulator: Accept pressed, app opened, nothing on screen.

Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com

The notification's Accept button has carried EXTRA_ANSWER_CALL since it was written, and nothing ever read it. Pressing Accept did what any other tap did: it opened the app. Answering was left to the next turn of the polling loop, which refuses a parked offer older than the caller's patience, so a call taken a little late opened the app onto nothing and looked like it had dropped the moment you answered it. MainActivity reads the extra now, on a cold start and on a warm one, and answers at once rather than waiting for a tick. The notification also goes away on its own when the offer it shows has expired. Before, it could outlive the offer by the gap between service sweeps, which is longer since the loop started holding its poll open, and during that gap it was a button that could only disappoint. Seen on the emulator: Accept pressed, app opened, nothing on screen. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
paulhitt commented 2026-09-10 18:47:23 +00:00 (Migrated from gitlab.com)

assigned to @paulhitt

assigned to @paulhitt
paulhitt commented 2026-09-10 19:08:02 +00:00 (Migrated from gitlab.com)

mentioned in commit 9bd86dd4f6

mentioned in commit 9bd86dd4f61a7aa1048a78d44c7226944cc1c923
paulhitt (Migrated from gitlab.com) merged commit 9bd86dd4f6 into main 2026-09-10 19:08:02 +00:00
Sign in to join this conversation.