Comments describe the code, not the edit that produced it
"This used to be drawn inside SignedIn", "nulling current first (as this used to)", "this used to report chat.peerId". Each keeps the reason it carried, written as the property rather than the change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
47ecffea39
commit
c26368b493
@@ -1080,10 +1080,10 @@ class CallManager(
|
||||
remoteVideoTrack = null
|
||||
main.post { runCatching { onVideoTracksChanged?.invoke() } }
|
||||
pendingOffer = null
|
||||
// ENDED fires while `current` still says who the call was with, the
|
||||
// observer files the call log entry from it, and nulling `current`
|
||||
// first (as this used to) meant NO call, answered or missed, was ever
|
||||
// recorded: by the time the state changed there was nobody to file.
|
||||
// ENDED fires while `current` still says who the call was with, and
|
||||
// the observer files the call log entry from it. Null `current` first
|
||||
// and no call, answered or missed, is ever recorded: by the time the
|
||||
// state changes there is nobody to file.
|
||||
state = State.ENDED
|
||||
current = null
|
||||
state = State.IDLE
|
||||
|
||||
@@ -1795,11 +1795,11 @@ fun ColumnScope.ChatScreen(
|
||||
reporting?.let { line ->
|
||||
// WHO wrote it, which in a group is not who the conversation is with.
|
||||
//
|
||||
// This used to report `chat.peerId`, and a group has none: `openGroup`
|
||||
// never sets it. So in a group the report menu opened, the reason was
|
||||
// chosen, Send was tapped, the sheet closed -- and `peerId?.let { }`
|
||||
// ran its block never, sending nothing and saying nothing. Silent, on
|
||||
// the one surface where somebody is most likely to need it. Block in
|
||||
// Not `chat.peerId`: a group has none, because `openGroup` never
|
||||
// sets it. Report it that way and in a group the menu opens, the
|
||||
// reason is chosen, Send is tapped, the sheet closes, and
|
||||
// `peerId?.let { }` never runs its block, sending nothing and saying
|
||||
// nothing on the one surface where somebody most needs it. Block in
|
||||
// the same sheet was dead the same way, and the sheet said "Block
|
||||
// Family chat" because it was handed the group's name.
|
||||
//
|
||||
|
||||
@@ -276,9 +276,9 @@ private fun Root(model: MessengerViewModel = viewModel()) {
|
||||
// banner is: an error belongs wherever the person is
|
||||
// standing when it happens.
|
||||
//
|
||||
// This used to be drawn inside `SignedIn`, which is the
|
||||
// HOME tab and nothing else, so anything that failed on
|
||||
// any other screen said why to an empty room. Posting a
|
||||
// Drawn outside `SignedIn`, which is the HOME tab and
|
||||
// nothing else: inside it, anything that failed on any
|
||||
// other screen said why to an empty room. Posting a
|
||||
// story is the clearest case: it refuses when the audience
|
||||
// is empty, sets a sentence explaining exactly that, and
|
||||
// the person watching the Stories tab saw the sheet close
|
||||
|
||||
@@ -284,11 +284,10 @@ object BackupPayload {
|
||||
s.optString("key").ifEmpty { s.optString("id") }.ifEmpty { s.optLong("at").toString() },
|
||||
)
|
||||
s.optJSONObject("set")?.let { out.put("set", it) }
|
||||
// Whether the strip has been watched. This used to be ours alone and
|
||||
// travelled anyway, on the grounds that it was the difference between a
|
||||
// strip remembering what you watched and one showing everything as new.
|
||||
// The iPhone turned out to HAVE the mark and not to be writing it, so
|
||||
// it relit every ring at each launch; both engines carry it now and it
|
||||
// Whether the strip has been watched. It is the difference between a
|
||||
// strip remembering what you watched and one showing everything as
|
||||
// new, so a phone that holds the mark without writing it relights
|
||||
// every ring at each launch. Both engines carry it and it
|
||||
// is in the canonical set rather than a divergence.
|
||||
if (s.optBoolean("seen", false)) out.put("seen", true)
|
||||
return out
|
||||
|
||||
Reference in New Issue
Block a user