The table went into 010_accounts.sql, which Fluent has already recorded as
applied. So it created itself perfectly on a fresh database and did nothing
at all on production — the deploy reported success and the table was not
there.
The warning for this is written on AddRateLimitCounters, in this same file,
because the identities table was nearly lost to it: "A NEW migration, not an
edit to InstallAccountsSchema. Fluent records what it has run and never runs
it twice, so appending this DDL to an applied migration would work perfectly
on a fresh database and silently do nothing on the deployed one." I read that
comment while writing the code that ignored it.
The baseline goes back to frozen, and the table lives in SQL/040 behind
AddAccountDevices, the way identities and rate limits do.
⚠️ No client sends a device id yet, so nothing was broken by the gap — the
INSERT is only reached when one is supplied. It would have broken sign-in for
the first client that did, which is a worse place to find it.
42 tests.
The table went into 010_accounts.sql, which Fluent has already recorded as
applied. So it created itself perfectly on a fresh database and did nothing
at all on production — the deploy reported success and the table was not
there.
The warning for this is written on AddRateLimitCounters, in this same file,
because the identities table was nearly lost to it: "A NEW migration, not an
edit to InstallAccountsSchema. Fluent records what it has run and never runs
it twice, so appending this DDL to an applied migration would work perfectly
on a fresh database and silently do nothing on the deployed one." I read that
comment while writing the code that ignored it.
The baseline goes back to frozen, and the table lives in SQL/040 behind
AddAccountDevices, the way identities and rate limits do.
⚠️ No client sends a device id yet, so nothing was broken by the gap — the
INSERT is only reached when one is supplied. It would have broken sign-in for
the first client that did, which is a worse place to find it.
42 tests.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The table went into 010_accounts.sql, which Fluent has already recorded as
applied. So it created itself perfectly on a fresh database and did nothing
at all on production — the deploy reported success and the table was not
there.
The warning for this is written on AddRateLimitCounters, in this same file,
because the identities table was nearly lost to it: "A NEW migration, not an
edit to InstallAccountsSchema. Fluent records what it has run and never runs
it twice, so appending this DDL to an applied migration would work perfectly
on a fresh database and silently do nothing on the deployed one." I read that
comment while writing the code that ignored it.
The baseline goes back to frozen, and the table lives in SQL/040 behind
AddAccountDevices, the way identities and rate limits do.
⚠️ No client sends a device id yet, so nothing was broken by the gap — the
INSERT is only reached when one is supplied. It would have broken sign-in for
the first client that did, which is a worse place to find it.
42 tests.
assigned to @paulhitt
mentioned in commit
022af50f2b