Production has run both of these since they were made. Main did not have them, so a rebuild from main would have put the 500 back and reopened /s/:shareID.
Verified live before merging: https://accounts.flamenet.io/healthz answers 200, /s/test and / answer 404, so the share route and the site controller are already gone from the running service.
The repository was archived with these two commits unmerged. Unarchived to land them, re-archived after.
845bd6fb adds the GRANT that 040_account_devices.sql never carried, plus the test that fails without it.
caf50d89 deletes ShareController, SiteController and the share routes.
No CI on this repository; it moved to Gitea with .gitlab-ci.yml only.
Production has run both of these since they were made. Main did not have them, so a rebuild from main would have put the 500 back and reopened /s/:shareID.
Verified live before merging: `https://accounts.flamenet.io/healthz` answers 200, `/s/test` and `/` answer 404, so the share route and the site controller are already gone from the running service.
The repository was archived with these two commits unmerged. Unarchived to land them, re-archived after.
- `845bd6fb` adds the GRANT that `040_account_devices.sql` never carried, plus the test that fails without it.
- `caf50d89` deletes ShareController, SiteController and the share routes.
No CI on this repository; it moved to Gitea with `.gitlab-ci.yml` only.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
🔴 Android sign-in returned "something went wrong on the server" for every
attempt. POST /sessions read the accounts row, then hit "permission denied
for table account_devices" reaching for the device list, and returned a
500.
The cause is a line in 010_accounts.sql that reads like a standing rule
and is not one:
GRANT ... ON ALL TABLES IN SCHEMA enclave_accounts TO accounts_service;
That grants what exists when it runs. Every table added afterwards arrives
readable by its owner alone. 020 and 030 both carry their own GRANT for
exactly this reason; 040 did not.
⚠️ Nothing about the failure pointed at grants. The app was up, the
database was up, the table existed with the right columns, and the person
signing in was told only that something had gone wrong. That is the whole
argument for the test: this class of bug is invisible until it is in
production, and then it looks like everything else.
Production was granted directly and sign-in verified — POST /sessions now
answers 401 for bad credentials instead of 500.
The test asserts every table created outside 010 is granted to
accounts_service, and was confirmed to FAIL with the grant removed and
pass with it restored, rather than being assumed to work.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The /s/:shareID page and the whole share API are gone.
It was cryptographically sound: only the id reached the server, the secret
rode in the URL fragment, and browsers do not transmit that — so the
server genuinely could not open what it served. What was wrong is what the
link IS. A bearer token for a classified document, pasteable into any
chat, mailable to anybody, forwardable for ever, and with nothing on the
far end that knows or cares what the file was labelled.
Sharing is inside the apps now: a document goes to a named contact through
the ratchet, carrying its label, and the sender is told who will be able
to open it. Worse for handing something to a stranger, which is the point.
⚠️ Checked before removing rather than after: five shares had ever been
created and none were still live, so no link in anybody's hands stopped
working.
The controller is deleted rather than commented out — code kept "in case"
is code the next reader has to work out the status of. The `shares` table
is left in place; dropping it is a migration and a separate decision from
closing the door.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Production has run both of these since they were made. Main did not have them, so a rebuild from main would have put the 500 back and reopened /s/:shareID.
Verified live before merging:
https://accounts.flamenet.io/healthzanswers 200,/s/testand/answer 404, so the share route and the site controller are already gone from the running service.The repository was archived with these two commits unmerged. Unarchived to land them, re-archived after.
845bd6fbadds the GRANT that040_account_devices.sqlnever carried, plus the test that fails without it.caf50d89deletes ShareController, SiteController and the share routes.No CI on this repository; it moved to Gitea with
.gitlab-ci.ymlonly.🤖 Generated with Claude Code