extant2000/flamenet-messenger-android
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Recognise an edit envelope so it is not drawn as a duplicate (§6.15) #39

Merged
paulhitt merged 1 commits from feat/edit-a-sent-message into main 2026-09-02 19:47:52 +00:00
Conversation 4 Commits 1 Files Changed 3
+204 -3
paulhitt commented 2026-09-02 09:38:38 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Without this branch an edit falls through parse to the last case, which
returns the caption as text — so an iPhone correcting a typo appears on
Android as a SECOND bubble beside the original, with nothing to say
either replaced the other. That is the bug this fixes today, before any
of the applying half exists.

isRenderable excludes it for the same reason it excludes a reaction, and
it is NOT in Kind.CONTROL: a build that swallowed it as generic control
would drop every correction silently, which is worse than the duplicate
because nobody would notice.

Codec only. Session.Line records no mid, so nothing in an Android
transcript can be named by an edit and the app cannot apply one. That is
the same gap reactions have been sitting behind (PARITY.md "codec done,
no UI") and one transcript change unlocks replies, reactions and edits
together — filed separately.

Refs paulhitt/flamenet-messenger-ios#26

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

Without this branch an edit falls through parse to the last case, which returns the caption as text — so an iPhone correcting a typo appears on Android as a SECOND bubble beside the original, with nothing to say either replaced the other. That is the bug this fixes today, before any of the applying half exists. isRenderable excludes it for the same reason it excludes a reaction, and it is NOT in Kind.CONTROL: a build that swallowed it as generic control would drop every correction silently, which is worse than the duplicate because nobody would notice. Codec only. Session.Line records no mid, so nothing in an Android transcript can be named by an edit and the app cannot apply one. That is the same gap reactions have been sitting behind (PARITY.md "codec done, no UI") and one transcript change unlocks replies, reactions and edits together — filed separately. Refs paulhitt/flamenet-messenger-ios#26 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
paulhitt commented 2026-09-02 09:38:38 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

assigned to @paulhitt

assigned to @paulhitt
paulhitt commented 2026-09-02 19:47:41 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 7 commits

  • d46ede3b...d1a438cd - 6 commits from branch main
  • 914112b0 - Recognise an edit envelope so it is not drawn as a duplicate (§6.15)

Compare with previous version

added 7 commits <ul><li>d46ede3b...d1a438cd - 6 commits from branch <code>main</code></li><li>914112b0 - Recognise an edit envelope so it is not drawn as a duplicate (§6.15)</li></ul> [Compare with previous version](/paulhitt/flamenet-messenger-android/-/merge_requests/12/diffs?diff_id=2000733630&start_sha=d46ede3b0b73ff3f3acbc9971036c669f37a49f4)
paulhitt commented 2026-09-02 19:47:53 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit bf44c15266

mentioned in commit bf44c15266a19ff6c0fd93ea453d0add8f09dd3e
paulhitt (Migrated from gitlab.com) merged commit bf44c15266 into main 2026-09-02 19:47:53 +00:00
paulhitt commented 2026-09-09 19:01:55 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

changed the description

changed the description
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accounts
accuracy
A public page or doc claims something the code does not do
 android
blocked:apple
Waiting on App Store review
 blocker
bug
enhancement
hardening
idea
messages
ops
Deploy, CI, infrastructure
 parity
One platform has it and the other does not
 privacy
Changes what is stored, or what we say is stored
 reliability
safety
security
tablet
tech-debt
testing
unwired
Built in the engine, not reachable from the UI
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
extant2000git
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: extant2000/flamenet-messenger-android#39