From 96b612597d8d4db49115202383975b54e28d9f7c Mon Sep 17 00:00:00 2001 From: Paul Hitt Date: Wed, 2 Sep 2026 15:30:21 -0400 Subject: [PATCH] A skipped live sign-up must report skipped, not passed The two live sign-up tests guarded themselves with a bare `return`, so without `-e live true` they finished immediately and reported PASSED. A test that did nothing and says it passed is worse than one that did not run: a suite of those is indistinguishable from a suite that works, which is the only reason to run it. `assumeTrue` instead, with the message saying how to opt in. Assumed-out shows as skipped, so the count reflects what was actually exercised. The iOS side already had this reasoning written down; Android had the comment's opposite. Compiles: :app:compileDebugAndroidTestKotlin. --- .../messenger/app/LiveSignUpFleetTest.kt | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/app/src/androidTest/kotlin/io/flamenet/messenger/app/LiveSignUpFleetTest.kt b/app/src/androidTest/kotlin/io/flamenet/messenger/app/LiveSignUpFleetTest.kt index 14b951a..6f9ff7d 100644 --- a/app/src/androidTest/kotlin/io/flamenet/messenger/app/LiveSignUpFleetTest.kt +++ b/app/src/androidTest/kotlin/io/flamenet/messenger/app/LiveSignUpFleetTest.kt @@ -92,15 +92,28 @@ class LiveSignUpFleetTest { signOutIfSignedIn() } + /** + * 🔴 `assumeTrue`, never a bare `return`. + * + * A bare return leaves the test reporting PASSED having done nothing, and + * a suite of those is indistinguishable from a suite that works — which is + * the whole reason to run it. Assumed-out shows as skipped, so the count + * tells the truth about what was actually exercised. + */ + private fun requireLiveOptIn() = + assumeTrue( + "pass -e live true to run these — they create real accounts on accounts.flamenet.io", + args.getString("live") == "true") + @Test fun signUpOnTheManagedRelay() { - assumeTrue("pass -e live true to run this - it creates real accounts", args.getString("live") == "true") + requireLiveOptIn() signUpLive(managed, "m") } @Test fun signUpOnASharedSelfHostedRelay() { - assumeTrue("pass -e live true to run this - it creates real accounts", args.getString("live") == "true") + requireLiveOptIn() signUpLive(sharedSelfHosted, "s") }