Remove machine-writing tells from comments and docs
Emoji markers, markdown bold inside code comments, and em-dashes are gone from source comments, string literals, scripts, Gradle files and the markdown docs. Counted before and after: emoji markers 2680 -> 1 (the emoji picker's own list, which is the feature) em-dashes 2490 -> 9 (table placeholders and fenced code) Two warning glyphs in user-facing strings in ChatScreens.kt are removed as well; the sentences say the same thing without them. Two backtick test names carried an em-dash and now carry a comma. Nothing else changed. 1208 tests pass, counted from the result XML. The three obfs4 interop tests are opted out with OBFS4_INTEROP_OPTOUT=1 for this run, as their own message instructs when no bridge is set up. CONTRIBUTING gets a four-line rule so it does not grow back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5.1
parent
04e06452b6
commit
4dd544083c
+11
-11
@@ -1,20 +1,20 @@
|
||||
#!/usr/bin/env bash
|
||||
# Publish a built release APK into the Flamenet F-Droid repository.
|
||||
#
|
||||
# 🔴 **This is OUR OWN repository, not a submission to f-droid.org.** The
|
||||
# This is OUR OWN repository, not a submission to f-droid.org. The
|
||||
# difference is not cosmetic: f-droid.org rebuilds from source and signs with
|
||||
# THEIR key, so an app already installed under our signature could not be
|
||||
# upgraded by it — Android refuses a differently-signed APK over an existing
|
||||
# upgraded by it. Android refuses a differently-signed APK over an existing
|
||||
# install. This repo indexes the APK we already signed, so it upgrades cleanly
|
||||
# for everybody who sideloaded from the website.
|
||||
#
|
||||
# 🔴 **The repo working directory holds a signing keystore and its password.**
|
||||
# It lives OUTSIDE every git checkout on purpose — all four repos are public.
|
||||
# The repo working directory holds a signing keystore and its password.
|
||||
# It lives OUTSIDE every git checkout on purpose, all four repos are public.
|
||||
# Never move it in, and never redirect (`>`) over config.yml: that file holds
|
||||
# the only on-disk copy of the keystore password, and this project has already
|
||||
# clobbered a credentials file that way once.
|
||||
#
|
||||
# ⚠️ The repo index key is permanent. Replacing it makes every client that has
|
||||
# The repo index key is permanent. Replacing it makes every client that has
|
||||
# added this repository reject its updates, silently, until they remove and
|
||||
# re-add it. Back up ~/flamenet-fdroid off this machine.
|
||||
#
|
||||
@@ -27,10 +27,10 @@ APK="${1:-app/build/outputs/apk/release/app-release.apk}"
|
||||
REMOTE="${FDROID_REMOTE:-ovh}"
|
||||
REMOTE_DIR="${FDROID_REMOTE_DIR:-/srv/prod/messenger/fdroid}"
|
||||
|
||||
[ -f "$APK" ] || { echo "no APK at $APK — build it first" >&2; exit 1; }
|
||||
[ -f "$APK" ] || { echo "no APK at $APK, build it first" >&2; exit 1; }
|
||||
[ -d "$FDROID_DIR" ] || { echo "no repo at $FDROID_DIR" >&2; exit 1; }
|
||||
[ -f "$FDROID_DIR/keystore.p12" ] || {
|
||||
echo "no keystore in $FDROID_DIR — refusing to re-init over a live repo" >&2; exit 1; }
|
||||
echo "no keystore in $FDROID_DIR, refusing to re-init over a live repo" >&2; exit 1; }
|
||||
|
||||
if [ -z "$FDROID_BIN" ]; then
|
||||
echo "set FDROID_BIN to the fdroid executable (a venv with fdroidserver)" >&2
|
||||
@@ -41,7 +41,7 @@ export JAVA_HOME="${JAVA_HOME:-/opt/homebrew/opt/openjdk@21}"
|
||||
export PATH="$JAVA_HOME/bin:$PATH"
|
||||
export ANDROID_HOME="${ANDROID_HOME:-$HOME/Library/Android/sdk}"
|
||||
|
||||
# Name the file by its real version, read out of the APK rather than typed —
|
||||
# Name the file by its real version, read out of the APK rather than typed,
|
||||
# same rule as the update manifest.
|
||||
aapt2="$(find "$ANDROID_HOME/build-tools" -maxdepth 2 -name aapt2 -type f | sort -V | tail -1)"
|
||||
badging="$("$aapt2" dump badging "$APK")"
|
||||
@@ -58,9 +58,9 @@ cd "$FDROID_DIR"
|
||||
"$FDROID_BIN" update --pretty
|
||||
|
||||
echo "syncing to $REMOTE:$REMOTE_DIR"
|
||||
# 🔴 Exclude fdroidserver's own status/ directory. It writes update.json and
|
||||
# running.json containing the ABSOLUTE PATHS of the build machine — the
|
||||
# maintainer's home directory, username, toolchain locations — and the fact
|
||||
# Exclude fdroidserver's own status/ directory. It writes update.json and
|
||||
# running.json containing the ABSOLUTE PATHS of the build machine, the
|
||||
# maintainer's home directory, username, toolchain locations, and the fact
|
||||
# that signing happens on that machine. Published, that is targeting data for
|
||||
# a supply-chain attack on the laptop holding the permanent Android release
|
||||
# key. fdroid's own `deploy` command excludes it; a raw rsync does not, so it
|
||||
|
||||
Reference in New Issue
Block a user