Remove machine-writing tells from comments and docs
Emoji markers, markdown bold inside code comments, and em-dashes are gone from source comments, string literals, scripts, Gradle files and the markdown docs. Counted before and after: emoji markers 2680 -> 1 (the emoji picker's own list, which is the feature) em-dashes 2490 -> 9 (table placeholders and fenced code) Two warning glyphs in user-facing strings in ChatScreens.kt are removed as well; the sentences say the same thing without them. Two backtick test names carried an em-dash and now carry a comma. Nothing else changed. 1208 tests pass, counted from the result XML. The three obfs4 interop tests are opted out with OBFS4_INTEROP_OPTOUT=1 for this run, as their own message instructs when no bridge is set up. CONTRIBUTING gets a four-line rule so it does not grow back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Paul Hitt
co-authored by
Claude Fable 5.1
Claude Fable 5.1
parent
04e06452b6
commit
4dd544083c
+15
-15
@@ -2,10 +2,10 @@
|
||||
# Run the on-device suites against a relay you named, on an emulator with no
|
||||
# history.
|
||||
#
|
||||
# 🔴 **Two ways an instrumented run silently points at PRODUCTION, and this
|
||||
# **Two ways an instrumented run silently points at PRODUCTION, and this
|
||||
# script closes both.**
|
||||
#
|
||||
# 1. The suites DEFAULT to a live host when no relay argument is passed —
|
||||
# 1. The suites DEFAULT to a live host when no relay argument is passed,
|
||||
# `FeatureUseTest` to relay1.flamenet.io, `LiveSignUpFleetTest` to
|
||||
# relay.flamenet.io. A plain `./gradlew connectedAndroidTest` therefore
|
||||
# signs accounts up on somebody's real server, and nothing in the output
|
||||
@@ -13,8 +13,8 @@
|
||||
# 2. A SAVED EMULATOR SNAPSHOT restores whatever the AVD was last doing.
|
||||
# Observed 2026-09-05: a snapshot signed in as `fnreviewbeta` against
|
||||
# relay.flamenet.io, restored under a test run that had been told to use a
|
||||
# local relay. Every one of the ten tests failed — they could not find the
|
||||
# sign-up screen, because the app was already signed in — and the reason
|
||||
# local relay. Every one of the ten tests failed, they could not find the
|
||||
# sign-up screen, because the app was already signed in, and the reason
|
||||
# was invisible until the failure's screen dump was read.
|
||||
#
|
||||
# Usage: scripts/instrumented.sh 10.0.2.2:18810 [ClassName ...]
|
||||
@@ -34,10 +34,10 @@ MSG
|
||||
}
|
||||
shift || true
|
||||
|
||||
# 🔴 Production is refused, not warned about. A run that creates accounts on
|
||||
# Production is refused, not warned about. A run that creates accounts on
|
||||
# relay.flamenet.io cannot be undone by noticing afterwards.
|
||||
#
|
||||
# ⚠️ relay1/relay2 are the TEST FLEET and are allowed — that is what they are
|
||||
# relay1/relay2 are the TEST FLEET and are allowed, that is what they are
|
||||
# for, and the suites need https because Android blocks cleartext, so a local
|
||||
# http relay cannot serve. Loud rather than silent: accounts really are created.
|
||||
case "$RELAY" in
|
||||
@@ -46,7 +46,7 @@ case "$RELAY" in
|
||||
echo "Use a test-fleet relay (relay1/relay2) or a local one." >&2
|
||||
exit 1;;
|
||||
*relay1.flamenet.io*|*relay2.flamenet.io*)
|
||||
echo "⚠️ $RELAY is a shared test relay — this run WILL create accounts on it." >&2;;
|
||||
echo "$RELAY is a shared test relay, this run WILL create accounts on it." >&2;;
|
||||
esac
|
||||
|
||||
CLASSES="${*:-io.flamenet.messenger.app.FeatureUseTest,io.flamenet.messenger.app.CrudSurfaceTest,io.flamenet.messenger.app.ChatFlowTest}"
|
||||
@@ -57,7 +57,7 @@ export JAVA_HOME="${JAVA_HOME:-/opt/homebrew/opt/openjdk@21}"
|
||||
ADB="$ANDROID_HOME/platform-tools/adb"
|
||||
AVD="${FN_AVD:-fnmsg-android-test}"
|
||||
|
||||
# ⚠️ `-no-snapshot-load` is the point of this block, and `-no-snapshot-save`
|
||||
# `-no-snapshot-load` is the point of this block, and `-no-snapshot-save`
|
||||
# keeps the next run clean too. A warm boot is faster and carries the last
|
||||
# session's account with it.
|
||||
if ! "$ADB" shell getprop sys.boot_completed 2>/dev/null | grep -q 1; then
|
||||
@@ -67,13 +67,13 @@ if ! "$ADB" shell getprop sys.boot_completed 2>/dev/null | grep -q 1; then
|
||||
-netdelay none -netspeed full >/tmp/fnmsg-emu.log 2>&1 &
|
||||
until "$ADB" shell getprop sys.boot_completed 2>/dev/null | grep -q 1; do sleep 5; done
|
||||
else
|
||||
echo "### emulator already up — clearing the app rather than trusting it"
|
||||
echo "### emulator already up, clearing the app rather than trusting it"
|
||||
"$ADB" uninstall io.flamenet.messenger >/dev/null 2>&1 || true
|
||||
"$ADB" uninstall io.flamenet.messenger.test >/dev/null 2>&1 || true
|
||||
fi
|
||||
|
||||
echo "### signed-in account on the device before we start:"
|
||||
"$ADB" shell pm list packages 2>/dev/null | grep -i flamenet || echo " (nothing installed — good)"
|
||||
"$ADB" shell pm list packages 2>/dev/null | grep -i flamenet || echo " (nothing installed, good)"
|
||||
|
||||
echo "### relay $RELAY · classes $CLASSES"
|
||||
set +e
|
||||
@@ -85,24 +85,24 @@ set +e
|
||||
STATUS=${PIPESTATUS[0]}
|
||||
set -e
|
||||
|
||||
# 🔴 **A skip is not a pass.** Every one of these suites opens with
|
||||
# A skip is not a pass. Every one of these suites opens with
|
||||
# `assumeTrue(relayReachable())`, so an unreachable relay produces a green
|
||||
# build that exercised nothing. Say which happened.
|
||||
# ⚠️ Anchored to the TEST line, not a bare "SKIPPED". Gradle prints
|
||||
# Anchored to the TEST line, not a bare "SKIPPED". Gradle prints
|
||||
# `> Task :app:preDebugAndroidTestBuild SKIPPED` for up-to-date tasks, so the
|
||||
# loose grep reported four skipped tests on a run where none were skipped —
|
||||
# loose grep reported four skipped tests on a run where none were skipped,
|
||||
# a verdict written to stop a skip reading as a pass, inventing skips instead.
|
||||
SKIPS=$(grep -cE "^io\.flamenet\..*SKIPPED" /tmp/fnmsg-instrumented.log || true)
|
||||
RAN=$(grep -oE "Finished [0-9]+ test" /tmp/fnmsg-instrumented.log | tail -1 || echo "")
|
||||
echo
|
||||
echo "### $RAN, $SKIPS skipped"
|
||||
if [ "$SKIPS" != "0" ] && [ "$STATUS" = "0" ]; then
|
||||
echo "### VERDICT: SKIPPED — the relay was unreachable. This is NOT a pass."
|
||||
echo "### VERDICT: SKIPPED, the relay was unreachable. This is NOT a pass."
|
||||
exit 3
|
||||
elif [ "$STATUS" = "0" ]; then
|
||||
echo "### VERDICT: PASSED on device"
|
||||
else
|
||||
echo "### VERDICT: FAILED — see /tmp/fnmsg-instrumented.log"
|
||||
echo "### VERDICT: FAILED, see /tmp/fnmsg-instrumented.log"
|
||||
echo "### and app/build/reports/androidTests/connected/debug/index.html"
|
||||
fi
|
||||
exit $STATUS
|
||||
|
||||
Reference in New Issue
Block a user