Remove machine-writing tells from comments and docs

Emoji markers, markdown bold inside code comments, and em-dashes are
gone from source comments, string literals, scripts, Gradle files and
the markdown docs. Counted before and after:

  emoji markers   2680 -> 1 (the emoji picker's own list, which is the feature)
  em-dashes       2490 -> 9 (table placeholders and fenced code)

Two warning glyphs in user-facing strings in ChatScreens.kt are removed
as well; the sentences say the same thing without them. Two backtick
test names carried an em-dash and now carry a comma.

Nothing else changed. 1208 tests pass, counted from the result XML.
The three obfs4 interop tests are opted out with OBFS4_INTEROP_OPTOUT=1
for this run, as their own message instructs when no bridge is set up.

CONTRIBUTING gets a four-line rule so it does not grow back.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Paul Hitt
2026-09-08 18:52:12 -04:00
co-authored by Claude Fable 5.1
parent 04e06452b6
commit 4dd544083c
277 changed files with 4885 additions and 4883 deletions
@@ -10,7 +10,7 @@ import kotlin.test.assertTrue
/**
* From a recovery phrase to an address somebody can be paid at.
*
* 🔴 **The property that matters most here is that the signing key and the
* **The property that matters most here is that the signing key and the
* displayed address come from the same derivation.** If they ever disagreed,
* the wallet would sign with a key that does not own the address it showed. The
* transaction being rejected is the GOOD outcome; the bad one is signing for an
@@ -27,7 +27,7 @@ class HdAccountTest {
// ---- The path --------------------------------------------------------
/**
* ⚠️ BIP-44 with every level hardened, which is what this curve requires
* BIP-44 with every level hardened, which is what this curve requires
* and what every other Solana wallet uses. A different shape here derives
* addresses nobody else can reproduce from the same phrase.
*/
@@ -41,7 +41,7 @@ class HdAccountTest {
// ---- The property that guards the money ------------------------------
/**
* 🔴 The signing key owns the address that was displayed. Everything else
* The signing key owns the address that was displayed. Everything else
* in the wallet rests on this one line being true.
*/
@Test
@@ -56,7 +56,7 @@ class HdAccountTest {
}
}
/** And that key can actually sign — the engine carries RFC 8032 itself. */
/** And that key can actually sign, the engine carries RFC 8032 itself. */
@Test
fun `a derived key can sign and the signature verifies under its address`() {
val account = account()
@@ -65,8 +65,8 @@ class HdAccountTest {
val message = "a transaction".toByteArray()
val signature = Ed25519.sign(seedAt0, message)
val publicKey = Base58.decode(shown.address)!!
// ⚠️ `(publicKey, signature, message)`. All three are ByteArray, so
// getting the order wrong compiles perfectly and fails at runtime —
// `(publicKey, signature, message)`. All three are ByteArray, so
// getting the order wrong compiles perfectly and fails at runtime,
// which is what happened writing this test, and is a good argument for
// the assertion existing at all.
assertTrue(Ed25519.verify(publicKey, signature, message),
@@ -76,8 +76,8 @@ class HdAccountTest {
// ---- Fresh addresses -------------------------------------------------
/**
* 🔴 **A new address per receive is the point.** Reusing one lets anybody
* watching a public chain group every payment somebody ever received — the
* A new address per receive is the point. Reusing one lets anybody
* watching a public chain group every payment somebody ever received, the
* one linkability a wallet can prevent, since the chain will not forget.
*/
@Test
@@ -112,7 +112,7 @@ class HdAccountTest {
// ---- Restoring -------------------------------------------------------
/**
* ⚠️ The whole promise of a recovery phrase: the same words give back the
* The whole promise of a recovery phrase: the same words give back the
* same addresses, on any device and any implementation.
*/
@Test
@@ -160,12 +160,12 @@ class HdAccountTest {
}
/**
* 🔴 **The limit, asserted as a passing test so nobody reads
* **The limit, asserted as a passing test so nobody reads
* `looksLikeAddress` as stronger than it is.**
*
* A Solana address carries NO checksum. A mistyped character that still
* decodes to 32 bytes is a perfectly valid address that nobody holds the
* key for — money sent there is gone, and neither this function nor the
* key for, money sent there is gone, and neither this function nor the
* network will catch it. Bitcoin's Base58Check would; this cannot.
*
* The only real defences are pasting rather than typing, and showing the
@@ -181,7 +181,7 @@ class HdAccountTest {
.firstOrNull { it != real && HdAccount.looksLikeAddress(it) }
assertTrue(
nearMiss != null,
"no single-character change produced a still-valid address — if this " +
"no single-character change produced a still-valid address, if this " +
"ever becomes true the format has gained a checksum, and the " +
"warnings written around typed addresses can be revisited",
)