This repository has been archived on 2026-10-15. You can view files and clone it. You cannot open issues or pull requests or push a commit.
Files
Paul HittandClaude Opus 5 3ad9a93449 Stop iOS choosing the passphrase, and fix recovering twice
Three bugs, all of which only appear the second time somebody needs the
account.

The passphrase field was `.textContentType(.newPassword)`, which invites
iOS to generate and insert a strong password. Accounts created through
this screen could then not be signed into with the passphrase that had
been typed into them — verified both ways with filesctl. Nothing looks
wrong at the time, because the app signs in with the same value it
registered with; it comes apart at the next sign-in. For a passphrase that
derives the keys and cannot be reset, a secret the person never read
leaves them with a recovery code as their only way back.

Recovery minted the replacement code twice — one for the account service,
a different one wrapped into the identity record and shown on screen. The
first recovery looked perfect and left the account openable only with a
code nobody had ever seen. One code now reaches both writes.

`EngineError` did not conform to `LocalizedError`, so a mistyped recovery
code reached the person who had just lost their passphrase as "The
operation couldn't be completed. (FilesEngine.EngineError error 1.)". The
reasons were always sentences at the throw site; now they survive.

Also: the recovery code is laid out four groups to a line so a group never
wraps in the middle — this is copied onto paper by hand, once — the
recovery screen scrolls so its only exit cannot sit off screen, and rows
this device can read come before the ones it cannot, so a new account does
not arrive at a screenful of "Encrypted for another key".

The UI suites are new: registration, sign-in, recovering (twice, which is
what catches the above), folders, upload, share links with the secret
asserted to be in the fragment, and a visual tour that photographs each
screen — the recovery code wrapping was found by looking, not by asserting.

⚠️ ProductionTourTests no longer carries a live credential for the
deployment. It was committed in plain text to a public repository, so the
account it belonged to has to be treated as compromised and its passphrase
changed; removing it here stops the leak continuing, it does not undo it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-22 20:27:00 -04:00

84 lines
2.7 KiB
YAML

# Generated with XcodeGen so the project file is not a merge hazard.
# `xcodegen generate` rebuilds it; the .xcodeproj is not committed.
name: FlamenetFiles
options:
bundleIdPrefix: io.flamenet
deploymentTarget:
iOS: "17.0"
createIntermediateGroups: true
packages:
FlamenetFiles:
path: .
targets:
FlamenetFiles:
type: application
platform: iOS
sources:
- path: App/Sources
- path: App/Resources
dependencies:
- package: FlamenetFiles
product: FilesEngine
- package: FlamenetFiles
product: FilesClient
info:
path: App/Info.plist
properties:
CFBundleDisplayName: Flamenet Files
CFBundleShortVersionString: "0.1"
CFBundleVersion: "1"
UILaunchScreen: {}
UISupportedInterfaceOrientations:
- UIInterfaceOrientationPortrait
# The app's own folder appears in Files. It stores nothing at rest —
# downloads go to a temporary directory and are handed straight to a
# share sheet — so there is no plaintext here to expose. It earns its
# place by letting people drop a file in from elsewhere, and by letting
# a UI test pick one through the real chooser rather than around it.
UIFileSharingEnabled: true
LSSupportsOpeningDocumentsInPlace: true
# Declares that the app uses only encryption exempt under the standard
# note. Without it, every TestFlight build stops for a compliance
# questionnaire.
ITSAppUsesNonExemptEncryption: false
# HTTPS everywhere by default. The exception is localhost, so a
# developer can point the app at a stack running on their own machine
# without weakening anything that ships.
NSAppTransportSecurity:
NSAllowsLocalNetworking: true
settings:
base:
PRODUCT_BUNDLE_IDENTIFIER: io.flamenet.files
SWIFT_VERSION: "6.0"
TARGETED_DEVICE_FAMILY: "1,2"
ENABLE_USER_SCRIPT_SANDBOXING: YES
FlamenetFilesUITests:
type: bundle.ui-testing
platform: iOS
sources: [AppTests]
dependencies:
- target: FlamenetFiles
settings:
base:
PRODUCT_BUNDLE_IDENTIFIER: io.flamenet.files.uitests
# A UI test bundle is code-signed like any other, and signing needs an
# Info.plist. Generated rather than checked in: there is nothing in it
# worth hand-editing, and its absence fails the build at the signing
# step with an error that does not mention tests.
GENERATE_INFOPLIST_FILE: YES
schemes:
FlamenetFiles:
build:
targets:
FlamenetFiles: all
FlamenetFilesUITests: [test]
run:
config: Debug
test:
config: Debug
targets: [FlamenetFilesUITests]